[PATCH 2/2] Support for Imperial units on MacDive log import

[Nick Shore]

On 08/02/2013, at 8:14 PM, Miika Turkia <miika.turkia at gmail.com> wrote:

> The main trouble with the format is the fields that are not well
> defined. E.g. weight seems to be a text field and I have seen samples
> that have only a number on it and samples with 10kg on it. My current
> conversion (not yet public) takes the best guess on this. Pure number
> is treated as being the unit specified (Metric or Imperial) - a safe
> assumption I believe. Anything else is passed to Subsurface parser
> hoping for the best. At least value like 10kg is treated properly in
> this case and totally bogus data is discarded as far as I know.


Weight is a tricky one. This is a freeform text string for compatibility with another application. Unfortunately the string is just parsed and a guess made as to what the data actually means. MacDive does exactly what you described.


> Just to make sure, is the second dive in your sample with bogus
> pressure readings (pressure going up and down without making sens,
> ending up with higher value than started with)?

Yes, they're just strange readings off my transmitter. Some dives the first samples are higher than what the device recorded as the start pressure, sometimes you get crazy spikes. I usually see the more extreme spikes when the connection is lost.

-nick