Depth validation in planner

[Sergey Starosek]

On Wed, Feb 13, 2013 at 12:56 PM, Robert C. Helling <helling at lmu.de> wrote:

> On Wed, 13 Feb 2013, Sergey Starosek wrote:
>
>  Hi,
>> During testing I've accidentally entered depth of 1000m with 1min
>> duration for the first segment. At this point application
>> stops responding for a long time and consumes 100% CPU on one of the
>> cores. Every focus change makes it even worse.
>>
>
>
> What worries me a bit more is that the plan that is shown in the notes is
> cut off as it is longer than the buffer in planner.c (2000 bytes). Could we
> extend this buffer size so we don't risk not showing a deco stop in a plan?
> Does it hurt to increase this buffer size by say a factor of 10? I mean,
> nobody is going to plan bounce dives to several hundret meters with
> subsurface, but let's just make sure.
>

Notes buffer of 2000 bytes is definitely small for UTF-8 locales: entering
first segment of 100m in 1min leads to a lot of errors:

 (subsurface:11213): Gtk-CRITICAL **: gtk_text_buffer_emit_insert:
assertion `g_utf8_validate (text, len, NULL)' failed

And notes field stays empty.

Sergey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130213/dceb0c86/attachment.html>