Still in time to change the table print ?

[Dirk Hohndel]

On Feb 14, 2013, at 9:21 PM, Miika Turkia wrote:

> On Fri, Feb 15, 2013 at 1:25 AM, Salvador Cuñat
> <salvador.cunat at gmail.com> wrote:
>> Good night.
>> 
>> Attached is the new patch, cleaned and included a little displacement
>> for the frame.
> 
> Looks good to me. I see all the vertical divisors.
> 
> However, some more possible tweaks: it seems to be possible that the
> right margin is too small. At least in some of my locations the last
> character goes over the right divisor (depends on where the word wrap
> hits). Also the bottom margin is not enough for chars like y and g
> (bottom does not bother in the same way the right margin does).

I played around with it briefly and decided to accept it this late in the game simply because it is a significant improvement with no obvious negative side effects...

Salvador, can you make the tweaks mentioned above on top of what I have committed and pushed out?

Look at this screenshot that really shows the two issues with right and bottom margin. The minutes are on the separation line and the 'J' of June clearly crosses into the horizontal line…




> The 8h45 style of showing time in English seems odd to me. Is it a standard way?

I think 8:45 would be more "international". But I think I would prefer it even more if you left out the day of the week and had it print in one row instead…
But that of course would modify a string for translation… so I think for 3.0 I'm ok with what we have.

Thanks for working on this and for sending an improved version of the patched based on feedback.

Just to avoid misunderstandings, for the tweaks suggested above, please pull what I pushed and send a patch relative to the latest master…

Thanks

/D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130215/bec9a6ce/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot from 2013-02-15 01:03:52.png
Type: image/png
Size: 24126 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130215/bec9a6ce/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4130 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130215/bec9a6ce/attachment-0001.bin>