Patch

[Rishubh Jain]

I am sorry for the silly mistakes...i am willing to correct my mistakes...I understand the indent problem and the commit message I will definitely improvise that, and will surely remove the qDebug() calls....but i still didnt get the idea of not using what i did..isnt it the same thing saving on the messge box or saving where you were editing?..please explain me if possible..and if you consider my trying to understand worthy of explanation..If not then it is ok

Thanking You
Rishubh





On Saturday, 8 March 2014 9:29 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
 
On Sat, 2014-03-08 at 23:00 +0800, Rishubh Jain wrote:
> Hey Dirk
> 
> 
> Please review my patch once more ...I think its usefull and i guess
> even few people like thiago thinks it will be usefull, 
> 
> It makes the UI a little more friendly

You have not read my response. You have not reacted to the explanation
in my response. Instead you keep sending messages urging me to
reconsider and apply your patch.

You have not addressed the issues that I raised with the formatting of
the patch (commit message), the formatting of the code (indentation), or
the issue that at the point where you inserted the code, calling
file_save() means that you will try to save an inconsistent state since
you are IN THE MIDDLE OF EDITING A DIVE.

No, the patch is wrong. You CANNOT simply save there.

Yes, I might be willing to consider a patch that tells the user "you're
in the middle of editing, do you really just want to throw away
everything?" (not those words, the idea) and offers "quit anyway" "go
back".

I will not accept a patch that calls file_save() at this spot.

Also, when redoing the patch, remove the qDebug() calls, please


/D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140309/bf58cf46/attachment-0001.html>