Invasive fix committed - please review and test
dirk at hohndel.org
Tue May 6 12:43:46 PDT 2014
On Tue, 2014-05-06 at 12:37 -0700, Linus Torvalds wrote:
> On Tue, May 6, 2014 at 11:21 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> > As indicated in my last email, the Qt version of Subsurface got the
> > multi edit semantics wrong. I just pushed two commits that I THINK fix
> > this, but I am understandably rather nervous about this.
> Looks ok to me. In various places we've considered the NULL pointer
> and an empty text field to be the same, and your EDIT_TEXT doesn't do
> that, but that seems like a small thing.
> I do think that a helper function for that string comparison would be
> a good idea. Just something like
> bool same_string(const char *a, const char *b)
> return !strcmp(a ? : "", b ? : "");
> would do it.
I like that.
I also realized that I missed a big chunk of the commit that dealt with
And then found a bug in that one. So that is being rewritten, too.
So 4.1 is not happening today. And likely not tomorrow, either :-(
More information about the subsurface