[Patch] Fix planner notes gas change output logic

[Robert Helling]

Hi,

> On 16.06.2015, at 13:08, Rick Walsh <rickmwalsh at gmail.com> wrote:
> 
> This patch corrects the logic.
> 
> Can someone more familiar with the planner code check that I've done the correct thing?  It works for me.


No, unfortunately, this is not correct either.

I acknowledge the bug that you describe (the gas change to EAN80 should be displayed at 9m depth). But your suggested patch breaks something else (which was the original motivation for the ‘postponed’ logic:

Start with air.

Descend to 20m
Stay there for 5min
Then switch gas to EAN80 and stay another 10min
Then switch back to air and stay a further 5min
ascent [planner ascends to 9m, should switch there back to EAN80 and then to the surface].

In my understanding the plan should then look like this:

depth
runtime
duration
gas
20m
1min
1min
air
20m
5min
4min
20m
15min
10min
EAN80
20m
20min
5min
 air
9m
22min
2min
EAN80
0m
28min
7min


I agree that this logic currently is completely incomprehensible. Will look at this later tonight again.

BTW, in another thread I sent a patch to reenable the notes.

Best
Robert

--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150616/1eeac37b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150616/1eeac37b/attachment-0001.sig>