[PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

Lubomir I. Ivanov neolit123 at gmail.com
Tue Apr 18 04:22:52 PDT 2017

On 18 April 2017 at 10:08, Stefan Fuchs <sfuchs at gmx.de> wrote:
> Hello Lubomir,
> Am 17.04.2017 um 23:53 schrieb Lubomir I. Ivanov:
> here are the updated Marble files and a patch diff for review.
> i can't build Marble to test these changes ATM though.
> Looks good, so long as "Marble::category" isn't too generic a name.
> ok, i've renamed it to Marable::loggingCategory.
> Stefan, could you please try building and running the attached patch?
> you can toggle the debugging with MarbleDebug::setEnabled(true/false)
> e.g. from the Subsurface source code.
> I will try it this morning.
> Two remaining questions:
> - What is the default state now if we don't set it explicitly? Enabled true
> or false?
> - Where would be the right place in Subsurface code to put the
> MarbleDebug::setEnabled(false) ?

we already do that in desktop-widgets/globe.cpp:


More information about the subsurface mailing list