Formatting Dive tags string

[Jérémie Guichard]

Hello Thiago,

In order to not mix the two topics in the same change, I decided to keep
the conversion to QString as it was in the original code, see:
https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/desktop-widgets/tab-widgets/maintab.cpp#L574
https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/desktop-widgets/tab-widgets/maintab.cpp#L1529
https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/qt-models/divetripmodel.cpp#L430
I can now prepare a follow up change that would deal with the issue you
have raised, the advantage is that now it must be fixed in a single place :)

Thanks for the feedback,

Jeremie

2018-04-05 5:27 GMT+02:00 Thiago Macieira <thiago at macieira.org>:

> On Wednesday, 4 April 2018 02:55:22 PDT Berthold Stoeger wrote:
> >   char *s = taglist_get_tagstring(...);
> >   QString tags(s);
> >   free(s);
>
> One minor note: this decodes the string as UTF-8. If your string is Latin1
> or
> plain US-ASCII, you should use QString::fromLatin1 or QLatin1String (same
> thing in this context).
>
> --
> Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
>    Software Architect - Intel Open Source Technology Center
>
>
>
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20180405/59895137/attachment-0001.html>